Review Request: Added Footnotes/Endnotes in References Tool

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102552/#review6727
-----------------------------------------------------------


I have seen some style issues. Please fix them in all your changed code. I will run cstester to see if there are any regressions.


libs/kotext/styles/KoStyleManager.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5935>

    You can just wite return 0 here;



libs/odf/KoOdfNumberDefinition.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5936>

    Please move the declaration to the line where it is first used, e.g. :
    int loop = ....
    
    The same is also true for the code further down.



libs/odf/KoOdfNumberDefinition.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5937>

    There should be a space between for and (
    
    Please fix all occurences of that.



libs/odf/KoOdfNumberDefinition.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5938>

    There should be a space betweeen if and (



libs/odf/KoOdfNumberDefinition.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5939>

    There should be a blank after ;



libs/odf/KoOdfStylesReader.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5940>

    As written in my last review this does not work like this as this code is only called when there is a notes configuration found in the styles.xml file.


- Thorsten


On Sept. 22, 2011, 12:29 p.m., Brijesh Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102552/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2011, 12:29 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> I worked on implementation of Footnotes and Endnotes in Calligra Words as part of my SoK project.
> Footnotes/Endnotes can now be inserted,saved,loaded and also be configured too.
> Can somebody review my work and notify me about bugs/crashes?
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoInlineNote.h 515a2f3 
>   libs/kotext/KoInlineNote.cpp 89200fd 
>   libs/kotext/KoInlineTextObjectManager.h 44990e9 
>   libs/kotext/KoInlineTextObjectManager.cpp da8d9ca 
>   libs/kotext/KoTextDocument.h a79638c 
>   libs/kotext/KoTextDocument.cpp 1265e2c 
>   libs/kotext/KoTextEditor.h 4947db8 
>   libs/kotext/KoTextEditor.cpp d6d6738 
>   libs/kotext/opendocument/KoTextLoader.cpp 04ce705 
>   libs/kotext/styles/KoStyleManager.h bae6eaf 
>   libs/kotext/styles/KoStyleManager.cpp 650899d 
>   libs/odf/KoOdfNotesConfiguration.cpp bc26e31 
>   libs/odf/KoOdfNumberDefinition.cpp d35a07f 
>   libs/odf/KoOdfStylesReader.cpp 35bffce 
>   libs/textlayout/CMakeLists.txt 5a4bfff 
>   libs/textlayout/FrameIterator.h c8be153 
>   libs/textlayout/FrameIterator.cpp fe9824e 
>   libs/textlayout/KoTextLayoutArea.h f356174 
>   libs/textlayout/KoTextLayoutArea.cpp 165b9cb 
>   libs/textlayout/KoTextLayoutArea_paint.cpp 6b3e293 
>   libs/textlayout/KoTextLayoutEndNotesArea.h 7b0c732 
>   libs/textlayout/KoTextLayoutEndNotesArea.cpp bb746db 
>   libs/textlayout/KoTextLayoutNoteArea.h PRE-CREATION 
>   libs/textlayout/KoTextLayoutNoteArea.cpp PRE-CREATION 
>   plugins/textshape/CMakeLists.txt 3df7aa5 
>   plugins/textshape/ReferencesTool.h c823be3 
>   plugins/textshape/ReferencesTool.cpp b210a35 
>   plugins/textshape/dialogs/NotesConfigurationDialog.h PRE-CREATION 
>   plugins/textshape/dialogs/NotesConfigurationDialog.cpp PRE-CREATION 
>   plugins/textshape/dialogs/NotesConfigurationDialog.ui PRE-CREATION 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.h 1af35a8 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.cpp 374b266 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.ui 77f33e7 
>   plugins/textshape/pics/settings-icon1_1.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102552/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brijesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110922/f915b0c3/attachment.htm>