Review Request: Added Footnotes/Endnotes in References Tool

[Casper Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102552/#review6624
-----------------------------------------------------------



libs/kotext/KoInlineNote.h
<http://git.reviewboard.kde.org/r/102552/#comment5843>

    remove



libs/kotext/KoInlineNote.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5844>

    remove



libs/kotext/KoInlineNote.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5845>

    remove



libs/kotext/KoInlineNote.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5847>

    hardly relevant, remove



libs/kotext/KoInlineNote.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5846>

    remove



libs/kotext/KoInlineNote.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5848>

    remove



libs/kotext/KoInlineTextObjectManager.h
<http://git.reviewboard.kde.org/r/102552/#comment5849>

    hmm we should these comments



libs/kotext/KoInlineTextObjectManager.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5850>

    remove



libs/kotext/KoInlineTextObjectManager.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5851>

    remove



libs/kotext/KoInlineTextObjectManager.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5852>

    don't do this change



libs/kotext/styles/KoSectionStyle.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5853>

    no extra line here please



libs/textlayout/KoTextLayoutArea.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5854>

    please add space on both sides of <



libs/textlayout/KoTextLayoutArea.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5855>

    not the best of comments. Though true it does more than that



libs/textlayout/KoTextLayoutArea.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5857>

    this->   is not needed



libs/textlayout/KoTextLayoutArea.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5856>

    please add spaces on both sides of <



libs/textlayout/KoTextLayoutEndNotesArea.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5858>

    please static too
    
    we don't want to pollute namespace



libs/textlayout/KoTextLayoutEndNotesArea.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5859>

    please add spaces on both sides of +



libs/textlayout/KoTextLayoutEndNotesArea.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5860>

    spaces both sides of <



libs/textlayout/KoTextLayoutEndNotesArea.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5861>

    spaces both sides of <



libs/textlayout/KoTextLayoutNoteArea.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5862>

    better:
    
    d->textLayout->draw(painter, QPointF(top(), left()));



libs/textlayout/KoTextLayoutNoteArea.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5863>

    remember the {



plugins/textshape/ReferencesTool.h
<http://git.reviewboard.kde.org/r/102552/#comment5864>

    showNotesConfigureDialog
    
    



plugins/textshape/ReferencesTool.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5865>

    absolute path to your own computer ??
    
    dont set an icon, and don't make it part of the patch



plugins/textshape/ReferencesTool.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5866>

    please try and make this work. it's a good initiative



plugins/textshape/dialogs/SimpleFootEndNotesWidget.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5867>

    space after ,



plugins/textshape/dialogs/SimpleFootEndNotesWidget.cpp
<http://git.reviewboard.kde.org/r/102552/#comment5868>

    space after ,


- Casper


On Sept. 18, 2011, 7:15 p.m., Brijesh Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102552/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2011, 7:15 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> I worked on implementation of Footnotes and Endnotes in Calligra Words as part of my SoK project.
> Footnotes/Endnotes can now be inserted,saved,loaded and also be configured too.
> Can somebody review my work and notify me about bugs/crashes?
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoInlineNote.h 515a2f3 
>   libs/kotext/KoInlineNote.cpp 89200fd 
>   libs/kotext/KoInlineTextObjectManager.h 44990e9 
>   libs/kotext/KoInlineTextObjectManager.cpp da8d9ca 
>   libs/kotext/KoTextEditor.h 4947db8 
>   libs/kotext/KoTextEditor.cpp d6d6738 
>   libs/kotext/opendocument/KoTextLoader.cpp 6ce4695 
>   libs/kotext/styles/KoSectionStyle.cpp 2f3a1ad 
>   libs/odf/KoOdfNotesConfiguration.cpp bc26e31 
>   libs/odf/KoOdfNumberDefinition.cpp d35a07f 
>   libs/odf/KoOdfStylesReader.cpp 35bffce 
>   libs/textlayout/CMakeLists.txt 5a4bfff 
>   libs/textlayout/FrameIterator.h c00a7a7 
>   libs/textlayout/FrameIterator.cpp 0702a2a 
>   libs/textlayout/KoTextLayoutArea.h f356174 
>   libs/textlayout/KoTextLayoutArea.cpp 9aefe33 
>   libs/textlayout/KoTextLayoutArea_paint.cpp 6b3e293 
>   libs/textlayout/KoTextLayoutEndNotesArea.h 7b0c732 
>   libs/textlayout/KoTextLayoutEndNotesArea.cpp bb746db 
>   libs/textlayout/KoTextLayoutNoteArea.h PRE-CREATION 
>   libs/textlayout/KoTextLayoutNoteArea.cpp PRE-CREATION 
>   plugins/textshape/CMakeLists.txt 3df7aa5 
>   plugins/textshape/ReferencesTool.h c823be3 
>   plugins/textshape/ReferencesTool.cpp b210a35 
>   plugins/textshape/dialogs/NotesConfigurationDialog.h PRE-CREATION 
>   plugins/textshape/dialogs/NotesConfigurationDialog.cpp PRE-CREATION 
>   plugins/textshape/dialogs/NotesConfigurationDialog.ui PRE-CREATION 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.h 1af35a8 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.cpp 374b266 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.ui 77f33e7 
>   plugins/textshape/pics/settings-icon1_1.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102552/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brijesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110918/48cb24d6/attachment.htm>