Review Request: Fix regression in size of shape groups with a lot of shapes

[Jan Hambrecht]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102645/#review6618
-----------------------------------------------------------


First I think in general it would be nice to have. I have two things to point out. First is that we must be absolutely sure that we catch all possible ways that the size of the group could change. If we miss one, we will have broken behaviour. Second it would be very nice to reuse the size member of KoShapePrivate if possible instead of introducing another member in KoShapeGroup.

- Jan


On Sept. 17, 2011, 7:19 a.m., Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102645/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2011, 7:19 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> With the fix for the group size now every time the function is called it calculates the size from its children.
> 
> When testing this with cstester I found problmes in the documents I uploaded to.
> 
> http://www.zagge.de/anchor/groupsize/
> 
> The problem there is that due the very huge amount of shapes in the group it takes now quite a very very long time to render the pages.
> 
> The patch fixes that problem by adding a cache to the group size and only recalculates the size when there was a change.
> 
> It additionally don't forward the ChildChanged when a CollisionDetection is encountered. The CollisonChanged is not needed to forward to any parent as if the results in a change this change will be probagated.
> 
> The patch is a very fast way to see on how to fix the problem and for me to get feedback if the way is the right one to go forward. 
> I will definitely clean it up more before it is ready for inclusion.
> The implementation of the shape container models needs to be moved to the cpp files and also the members will be put into the d pointer.
> 
> Looking forward to your feedback.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShapeContainerModel.cpp 7995236 
>   libs/flake/KoShapeGroup.h a53d2ad 
>   libs/flake/KoShapeGroup.cpp 409b18c 
>   libs/flake/ShapeGroupContainerModel.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102645/diff
> 
> 
> Testing
> -------
> 
> Before the patch switching between slides in the www.renaissance.co.il%2Fivbug%2Fmeeting87%2FArchitecture%20and%20design%20patterns.ppt file takes more then 10 seconds, with the patch it is instantly.
> 
> Tested resizing of groups of groups, resizing/modifying of shapes in groups. 
> 
> 
> Thanks,
> 
> Thorsten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110918/a289571e/attachment.htm>