Review Request: Add icons to document structure docker context menu

Thorsten Zachmann t.zachmann at zagge.de
Sun Sep 18 09:06:35 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102627/#review6616
-----------------------------------------------------------

Ship it!


Looks good please commit. Please fix the one thing I commented.


libs/kopageapp/KoPADocumentStructureDocker.cpp
<http://git.reviewboard.kde.org/r/102627/#comment5842>

    This line should be different for slide and page basaed applications. 
    
    If slide or page should be used canbe checked by
    
    KoPADocument::pageType() == KoPageApp::Slide


- Thorsten


On Sept. 15, 2011, 9:25 p.m., Paul Mendez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102627/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2011, 9:25 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Add icons to document structure docker context menu, to make it consistent with Stage slides sorter contex menu.
> 
> 
> Diffs
> -----
> 
>   libs/kopageapp/KoPADocumentStructureDocker.cpp 1a8caaa432d89574e61ea34c084bddf357eb40f5 
> 
> Diff: http://git.reviewboard.kde.org/r/102627/diff
> 
> 
> Testing
> -------
> 
> Build and run
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110918/96af0964/attachment.htm>


More information about the calligra-devel mailing list