Review Request: Add frame preview support (aka PNG/SVG Previews)

[Jan Hambrecht]

> On Sept. 16, 2011, 12:33 p.m., Jan Hambrecht wrote:
> > libs/flake/KoShapeRegistry.cpp, line 169
> > <http://git.reviewboard.kde.org/r/102512/diff/5/?file=36175#file36175line169>
> >
> >     Excessive whitespace, please remove.
> 
> Inge Wallin wrote:
>     This is getting into the zander domain...
> 
> Jan Hambrecht wrote:
>     Inge I would appreciate if you don't play that card. I really feel offended by that comment. If you think we should not comment on style issues then please bring that forward on the mailing list, then we can make it a policy.
> 
> Inge Wallin wrote:
>     I'm sorry for that.  It was my annoyance that spoke here.
>     
>     I don't mind the policy, but I think that a simple "please take care of all the end-of-line whitespace before pushing" when you press "ship it" is enough.  It is actually a fair amount of work to create a patch, upload it to reviewboard, and create the new diff generation there. To force this amount of work just for a few spaces when we are already at diff generation 5 is a bit too much in my mind.
>     
>     And again, sorry for the comment. It's just that zander plagued me with exactly that so much that I'm extra sensitive.

I did the one line comment in my last review.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102512/#review6566
-----------------------------------------------------------


On Sept. 16, 2011, 4:15 p.m., Dan Leinir Turthra Jensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102512/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2011, 4:15 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Add the ability to use previews for frames with unsupported formats. It will show the embedded objects in order of preference. If the first object is not recognised, the new Unavail shape will be used, which will then try the other options in turn, and for each attempt to load a Picture shape, and upon success it will load the data and disable the Picture shape's tools (to avoid confusion etc). Finally, if no object is recognised, a question mark image is shown, to indicate that the object is unknown.
> 
> Work done by Inge Wallin and Dan Leinir Turthra Jensen.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShapeRegistry.cpp a65b1c9 
>   libs/flake/KoUnavailShape.h fb346f7 
>   libs/flake/KoUnavailShape.cpp c9bfc77 
> 
> Diff: http://git.reviewboard.kde.org/r/102512/diff
> 
> 
> Testing
> -------
> 
> compiled, run and functionality tested by ingwa
> 
> 
> Thanks,
> 
> Dan Leinir Turthra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110916/b1856f76/attachment.htm>