Review Request: Add frame preview support (aka PNG/SVG Previews)

[Jan Hambrecht]

> On Sept. 16, 2011, 12:33 p.m., Jan Hambrecht wrote:
> > libs/flake/KoShapeRegistry.cpp, line 169
> > <http://git.reviewboard.kde.org/r/102512/diff/5/?file=36175#file36175line169>
> >
> >     Excessive whitespace, please remove.
> 
> Inge Wallin wrote:
>     This is getting into the zander domain...

Inge I would appreciate if you don't play that card. I really feel offended by that comment. If you think we should not comment on style issues then please bring that forward on the mailing list, then we can make it a policy.


> On Sept. 16, 2011, 12:33 p.m., Jan Hambrecht wrote:
> > libs/flake/KoShapeRegistry.cpp, lines 162-168
> > <http://git.reviewboard.kde.org/r/102512/diff/5/?file=36175#file36175line162>
> >
> >     I am not sure the logic explained here is what we want. There might be another shape which can load the second representation of the frame content. I think the unavailable shape should be the very last resort, i.e. if none of all the different representations of the frame content could be loaded by any other shape.
> >     Or do I miss something here?
> 
> Inge Wallin wrote:
>     Yes, you are missing something.
>     
>     A frame can have several different contents.  But they all represent the same thing.  It is *only* the first content that is the actual data; all the other ones (normally just one) are image representations of the actual data in the first part.
>     
>     This means that if we cannot load the first part (which contains the actual data) we can never recreate it by using the second, third or whatever part. If we cannot load the first one, then the unavail shape should kick in and save the ununderstood and unparsed data in the first part. It is a bonus that it also shows one of the images in part 2, 3 or whatever. 
>     
>     If you let any other shape show part 2 we have lost the data and it will never be recovered.

I see, then please forget my comment.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102512/#review6566
-----------------------------------------------------------


On Sept. 15, 2011, 3:05 p.m., Dan Leinir Turthra Jensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102512/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2011, 3:05 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Add the ability to use previews for frames with unsupported formats. It will show the embedded objects in order of preference. If the first object is not recognised, the new Unavail shape will be used, which will then try the other options in turn, and for each attempt to load a Picture shape, and upon success it will load the data and disable the Picture shape's tools (to avoid confusion etc). Finally, if no object is recognised, a question mark image is shown, to indicate that the object is unknown.
> 
> Work done by Inge Wallin and Dan Leinir Turthra Jensen.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShapeRegistry.cpp a65b1c9 
>   libs/flake/KoUnavailShape.h fb346f7 
>   libs/flake/KoUnavailShape.cpp c9bfc77 
> 
> Diff: http://git.reviewboard.kde.org/r/102512/diff
> 
> 
> Testing
> -------
> 
> compiled, run and functionality tested by ingwa
> 
> 
> Thanks,
> 
> Dan Leinir Turthra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110916/f007b572/attachment.htm>