Review Request: Create text box when double click in default tool

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102629/#review6553
-----------------------------------------------------------



plugins/defaultTools/defaulttool/DefaultTool.cpp
<http://git.reviewboard.kde.org/r/102629/#comment5791>

    This include seems to not be used anywhere.



plugins/defaultTools/defaulttool/DefaultTool.cpp
<http://git.reviewboard.kde.org/r/102629/#comment5792>

    As boemann has already said this method to check if double-click should create a TOS is not good. It should be configurable in the application if it should happen or not.  Maybe using a cancas resourse might be an option



plugins/defaultTools/defaulttool/DefaultTool.cpp
<http://git.reviewboard.kde.org/r/102629/#comment5795>

    The adding of a tos needs to be done in a command so that it be undone.
    
    The adding to the document needs to be done like in KoShapeCreateCommand::redo.


- Thorsten


On Sept. 16, 2011, 9:29 a.m., Yue Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102629/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2011, 9:29 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Changed double click behavior of default tool. Previously double click on a path shape will enter path edit mode, but more often user expect creating a text box on the shape. Now double click will create a textbox on the shape in all applications except karbon, which is more concentrated on graphic editing.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoTosContainer.h a2162f0 
>   plugins/defaultTools/defaulttool/DefaultTool.cpp ccfce0e 
> 
> Diff: http://git.reviewboard.kde.org/r/102629/diff
> 
> 
> Testing
> -------
> 
> Runs correctly on each app. But when moving textshape attached shapes there are some flickers when updating the textshape.
> 
> 
> Thanks,
> 
> Yue
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110916/5889d4a6/attachment.htm>