Review Request: Make it possible to get a all draw styles of a defined type.

Thorsten Zachmann t.zachmann at zagge.de
Sun Sep 11 05:49:32 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102562/
-----------------------------------------------------------

(Updated Sept. 11, 2011, 4:49 a.m.)


Review request for Calligra.


Changes
-------

Comment the function as proposed by Casper and Jan. I still use a string as that is more in line with the other methods in this class.


Summary
-------

This patch makes it possible to get all gradients, markers, ...  from the styles reader. It is needed when we don't want to load the same stuff over and over again. 
I will use it in my marker branch to get all markers and load them in one go and just reuse them later.

There is no change in functionality for the extiting applications.


Diffs (updated)
-----

  libs/odf/KoOdfStylesReader.h acab80f 
  libs/odf/KoOdfStylesReader.cpp 5a8324e 
  plugins/chartshape/Surface.cpp e22a6b2 
  libs/flake/KoPatternBackground.cpp 4210ab48 
  libs/odf/KoOdfGraphicStyles.cpp 9e9653f 

Diff: http://git.reviewboard.kde.org/r/102562/diff


Testing
-------

Run cstester and no problems found in the documents of my test set (~1500 docs)


Thanks,

Thorsten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110911/07273e4e/attachment.htm>


More information about the calligra-devel mailing list