Review Request: Add support to fo:clip property in pictureshape

Casper Boemann cbr at boemann.dk
Sat Sep 10 17:53:21 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102570/#review6394
-----------------------------------------------------------


I'm a bit catious about your pt to pixel conversions. let's investigate on irc


libs/flake/KoImageData.cpp
<http://git.reviewboard.kde.org/r/102570/#comment5684>

    is this expensive when wanted region is full image??



libs/flake/KoImageData.cpp
<http://git.reviewboard.kde.org/r/102570/#comment5685>

    don't forget { } even for single line if



plugins/pictureshape/PictureShape.h
<http://git.reviewboard.kde.org/r/102570/#comment5686>

    please format the code appropriately



plugins/pictureshape/PictureShape.h
<http://git.reviewboard.kde.org/r/102570/#comment5687>

    hmm these looks wrong, what are you trying to achive


- Casper


On Sept. 10, 2011, 5:26 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102570/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2011, 5:26 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Adds support to fo:clip ODF property. In https://bugs.kde.org/show_bug.cgi?id=281531 the whole image is scaled and shown insted of clipping. With this patch pictureshape now supports clipping.
> Known Issue: The doc file attacted to the bug report will be displayed as before because of the filter problem. If the MS doc file is converted to ODT using LO or OOo and then opened in Words the image is displayed similar to LO or OOo.
> 
> 
> This addresses bug 281531.
>     http://bugs.kde.org/show_bug.cgi?id=281531
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoImageData.h 3556100 
>   libs/flake/KoImageData.cpp da93926 
>   libs/flake/KoImageData_p.h 6eba4bc 
>   plugins/pictureshape/PictureShape.h 5c362fb 
>   plugins/pictureshape/PictureShape.cpp cba8cc4 
> 
> Diff: http://git.reviewboard.kde.org/r/102570/diff
> 
> 
> Testing
> -------
> 
> Converted the MS doc file attached to https://bugs.kde.org/show_bug.cgi?id=281531 to ODT in LO and saw that the picture is displayed similarly in LO and Words.
> 
> 
> Thanks,
> 
> Gopalakrishna
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110910/252e9e0e/attachment.html>


More information about the calligra-devel mailing list