Review Request: Load plugins from KPartPlugins directory - Stage

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102546/#review6318
-----------------------------------------------------------


I know it's needed indeed, we needed that in our view class in krita as well. But I'm not sure anymore actually why... But the fix is good.

- Boudewijn


On Sept. 7, 2011, 8:20 a.m., Mani Chandrasekar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102546/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2011, 8:20 a.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Summary
> -------
> 
> Stage is not loading plugins to its menu, patch would load them to it. 
> 
> Though this patch works as it should, I did not understand the reason for adding this line again in KPrView.cpp. I tried enabling loadPlugin in KPrDocument setComponent(KPrFactory::componentData(), true) But this did not work. 
> 
> Could someone explain why it did not work and reason behind calling setComponent again ?
> 
> 
> Diffs
> -----
> 
>   stage/part/KPrView.cpp 446d0b5 
> 
> Diff: http://git.reviewboard.kde.org/r/102546/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mani
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110907/af63bcc1/attachment.htm>