Review Request: Add frame preview support (aka PNG/SVG Previews)

Thorsten Zachmann t.zachmann at zagge.de
Fri Sep 2 05:17:12 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102512/#review6226
-----------------------------------------------------------



libs/flake/KoUnavailShape.cpp
<http://git.reviewboard.kde.org/r/102512/#comment5482>

    The content of the files should not be put to memory as that can be quite big. It should use temporary files for that as the content is not needed at all a temporary file make more sense.
    


- Thorsten


On Sept. 1, 2011, 9:31 p.m., Dan Leinir Turthra Jensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102512/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2011, 9:31 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Add the ability to use previews for frames with unsupported formats. It will show the embedded objects in order of preference. If the first object is not recognised, the new Unavail shape will be used, which will then try the other options in turn, and for each attempt to load a Picture shape, and upon success it will load the data and disable the Picture shape's tools (to avoid confusion etc). Finally, if no object is recognised, a question mark image is shown, to indicate that the object is unknown.
> 
> Work done by Inge Wallin and Dan Leinir Turthra Jensen.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShapeRegistry.cpp a65b1c9 
>   libs/flake/KoUnavailShape.h fb346f7 
>   libs/flake/KoUnavailShape.cpp c9bfc77 
> 
> Diff: http://git.reviewboard.kde.org/r/102512/diff
> 
> 
> Testing
> -------
> 
> compiled, run and functionality tested by ingwa
> 
> 
> Thanks,
> 
> Dan Leinir Turthra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110902/ba1b78ce/attachment.htm>


More information about the calligra-devel mailing list