Review Request: Some small fixes for latex exports
Thorsten Zachmann
t.zachmann at zagge.de
Fri Sep 2 05:07:26 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102467/#review6225
-----------------------------------------------------------
Just a shot comment about a++ and ++a. I think i cases where both can be used we should stick to ++a, as it can be faster in some cases (should not matter in the used ones) See http://www.parashift.com/c++-faq-lite/operator-overloading.html#faq-13.15 for more details.
- Thorsten
On Aug. 28, 2011, 11:23 a.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102467/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2011, 11:23 a.m.)
>
>
> Review request for Calligra.
>
>
> Summary
> -------
>
> Check the array index before accessing the array.
> Change the check of the array index from <= to <.
> Check zone abailability before accessing it.
> change a=a+1 to a++.
>
>
> Diffs
> -----
>
> filters/tables/latex/export/table.cc 54f2811
> filters/words/latex/export/para.cc f77c80c
> filters/words/latex/export/table.cc 112f698
>
> Diff: http://git.reviewboard.kde.org/r/102467/diff
>
>
> Testing
> -------
>
> No changes in make tests output.
>
>
> Thanks,
>
> Jaime Torres
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110902/cdb1030e/attachment.htm>
More information about the calligra-devel
mailing list