Review Request: Fix crashing when using tools on empty image
Boudewijn Rempt
boud at valdyas.org
Mon Oct 31 22:19:41 GMT 2011
On Monday 31 October 2011 Oct, Torio Mlshi wrote:
>
> > On Oct. 31, 2011, 7:43 p.m., Dmitry Kazakov wrote:
> > > Thanks for the fix! =)
> > > Just two small things:
> > > 1) I think it would be logical to reset the stroke id right after endStroke(m_strokeId) in mouseReleaseEvent() function. Like:
> > > image->endStroke(m_strokeId);
> > > m_strokeId.clear();
> > > 2) And we are using kde coding style for positioning braces around 'if's ;) [1]
> > >
> > >
> > > [1] - http://techbase.kde.org/Policies/Kdelibs_Coding_Style
>
> Fixed & pushed. And thanks for the link: I was really confused about format rules as there are different pieces with different style (probably old code) =)
>
Oh, yes, there's so much old code around... We try to make sure the new style is used in all new code, though.
--
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
More information about the calligra-devel
mailing list