Review Request: Fix zooming and keep the preferred center

Boudewijn Rempt boud at valdyas.org
Sun Oct 30 10:49:48 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102988/#review7763
-----------------------------------------------------------

Ship it!


I'm fine with the change.


libs/flake/KoCanvasControllerWidget.cpp
<http://git.reviewboard.kde.org/r/102988/#comment6653>

    Maybe remove these new debug lines? They look temporary.


- Boudewijn Rempt


On Oct. 29, 2011, 3:42 p.m., Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102988/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2011, 3:42 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> When zooming in stage the center is not kept and the zooming does not happen naturally. The problem is that the prefered center was recalaulated as the signal was not set to blocked. Moving the line fixes that.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoCanvasControllerWidget.cpp 2e6f1cd 
> 
> Diff: http://git.reviewboard.kde.org/r/102988/diff/diff
> 
> 
> Testing
> -------
> 
> Tested in stage, karbon, krita and words. It works fine in all 4 however there is a repainting problem in words that is unrelared to the patch.
> 
> 
> Thanks,
> 
> Thorsten Zachmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111030/7494cae1/attachment.htm>


More information about the calligra-devel mailing list