Review Request: A Simple patch adding automatic Changing of the Current ToolbarTab when Switching to Design mode for forms/report respectively.

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102928/#review7585
-----------------------------------------------------------



kexi/main/KexiMainWindow.cpp
<http://git.reviewboard.kde.org/r/102928/#comment6574>

    Please fix indentation, 'break' in new row, add "default:" case.
    



kexi/main/KexiMainWindow.cpp
<http://git.reviewboard.kde.org/r/102928/#comment6575>

    Only do that for form and report, right?



kexi/main/KexiMainWindow_p.h
<http://git.reviewboard.kde.org/r/102928/#comment6577>

    - change to setCurrentTab(const QString &name)
    
    - no space before (



kexi/main/KexiMainWindow_p.h
<http://git.reviewboard.kde.org/r/102928/#comment6578>

    -> setCurrentTab(name)


- Jarosław Staniek


On Oct. 23, 2011, 9:36 p.m., Dimitrios Tanis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102928/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2011, 9:36 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> A Simple patch adding automatic Changing of the Current ToolbarTab when Switching to Design mode for forms/report respectively.
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiMainWindow.cpp f54e761 
>   kexi/main/KexiMainWindow_p.h 32d45f5 
> 
> Diff: http://git.reviewboard.kde.org/r/102928/diff/diff
> 
> 
> Testing
> -------
> 
> Compiles and runs without errors.
> 
> Minor issue. It works when switching to design view from the Project Navigator, but it does NOT work when switching from the objects toolbar (ie the toolbar displayed under the object tab).
> Maybe switching to design is implemented by two different slots? Looking into it.
> 
> 
> Thanks,
> 
> Dimitrios Tanis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111024/047ec964/attachment.htm>