Review Request: Fix loading/saving clone layers

[Dmitry Kazakov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102896/#review7512
-----------------------------------------------------------

Ship it!


Great work! =)

- Dmitry Kazakov


On Oct. 20, 2011, 4:17 p.m., Torio Mlshi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102896/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2011, 4:17 p.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Description
> -------
> 
> This patch fixes saving and loading of clone layers. It adds uuid to KisBaseNode so that clone layers use it to store information about their targets, making sure to target required layer.
> 
> About compatibility:
> All nodes get uuid on creation. So node will have uuid even if no one is provided in file (which overwrites if present). Clone layers also use old code if no copyfromuuid field. So old files should work fine.
> And new files should also be loaded ok by old versions because no fields are removed and old fields (such as copyfrom) are still valid. Of course, old versions will open new files just as old ones and bug will still present there.
> 
> 
> This addresses bug 283610.
>     http://bugs.kde.org/show_bug.cgi?id=283610
> 
> 
> Diffs
> -----
> 
>   krita/image/CMakeLists.txt d4e4768 
>   krita/image/kis_clone_info.h PRE-CREATION 
>   krita/image/kis_clone_info.cpp PRE-CREATION 
>   krita/image/kis_clone_layer.h 5af727d 
>   krita/image/kis_clone_layer.cpp 8d9188c 
>   krita/ui/kra/kis_kra_load_visitor.h 854f6e3 
>   krita/ui/kra/kis_kra_load_visitor.cpp eb392f6 
>   krita/ui/kra/kis_kra_loader.cpp 58e64cb 
>   krita/ui/kra/kis_kra_savexml_visitor.cpp 17c1365 
> 
> Diff: http://git.reviewboard.kde.org/r/102896/diff/diff
> 
> 
> Testing
> -------
> 
> Old files worked fine, as expected.
> 
> 
> Thanks,
> 
> Torio Mlshi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111020/804ba2ae/attachment.htm>