Review Request: Don't crash when creating a view in Tables
Boudewijn Rempt
boud at valdyas.org
Wed Oct 19 09:58:19 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102916/#review7484
-----------------------------------------------------------
Ship it!
Ship It!
- Boudewijn Rempt
On Oct. 19, 2011, 8:54 a.m., Dan Leinir Turthra Jensen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102916/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2011, 8:54 a.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Previously the Tables code would crash when attempting to create a view directly from a document instance. This patch fixes the issue, and makes use of the fix to reduce the complexity of the calligraconverter code.
>
>
> Diffs
> -----
>
> tables/part/Doc.cpp 67c128f
> tools/converter/CMakeLists.txt 5f7f68b
> tools/converter/calligraconverter.cpp 8fe68cc
>
> Diff: http://git.reviewboard.kde.org/r/102916/diff/diff
>
>
> Testing
> -------
>
> Open documents in Calligra Tables, and use calligraconverter to convert some documents to pdf
>
>
> Thanks,
>
> Dan Leinir Turthra Jensen
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111019/8b4309d8/attachment.htm>
More information about the calligra-devel
mailing list