Review Request: New UI for words, some hopefully insignificat changes to other apps

[Thomas Pfeiffer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102871/#review7424
-----------------------------------------------------------


This is a very good idea for tabs with more than one element in them (e.g. Text editing, References, Review).

What it does not make sense for are those tabs that contain only one or two buttons (e.g. zoom and pan). Tabs are used to split up a UI in different sections, not to change the cursor, so chaning the cursor by clicking a tab would be unexpected behavior.
Just placing a single button in those tabs which only changes the cursor would make the whole thing slow and cumbersome.

Things like pan and zoom should go to the main toolbar as they don't do document manipulation anyway. If we want to allow users to hide the toolbar altogether but still have those tools, we need to find a different place. But I don't think they are of the same type as things like the text editing tab.


- Thomas Pfeiffer


On Oct. 15, 2011, 4:49 p.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102871/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2011, 4:49 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This UI was conceived during the KDE User Experience sprint in Berlin 2011
> 
> It basically provides a drop-in-replacement for the toolbox + tooloptionsdocker in the form of a single docker containing QToolBox widget.
> 
> The new KoModeBox is used in Words only. All the other applications should be left unchanged.
> 
> The tools have a new extended usage of the Type attribute. See the KoToolFactoryBase.h changes for description. It should be compatible with the krita usage.
> The only visible changes outside Words would probably be that the gradient, pattern,calligraphy tools end up in a separate section of the toolbox.
> 
> 
> Diffs
> -----
> 
>   karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyToolFactory.cpp cb1c092 
>   karbon/plugins/tools/KarbonGradientToolFactory.cpp 786d98a 
>   karbon/plugins/tools/KarbonPatternToolFactory.cpp 1ec250fa 
>   karbon/plugins/tools/KarbonPencilToolFactory.cpp 4fd1105 
>   karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsToolFactory.cpp c30f1be 
>   libs/flake/KoToolFactoryBase.h 73f2534 
>   libs/flake/KoToolManager.cpp 3bcae08 
>   libs/main/CMakeLists.txt 9539a5a 
>   libs/main/KoDockerManager.h 7e44455 
>   libs/main/KoDockerManager.cpp 7f5b17d 
>   libs/main/KoModeBox.cpp PRE-CREATION 
>   libs/main/KoModeBoxFactory.h PRE-CREATION 
>   libs/main/KoModeBoxFactory.cpp PRE-CREATION 
>   libs/main/KoModeBox_p.h PRE-CREATION 
>   libs/main/KoToolBox.cpp ede46d4 
>   plugins/textshape/ReferencesToolFactory.cpp 096e602 
>   plugins/textshape/ReviewToolFactory.cpp bbd6452 
>   plugins/textshape/TextToolFactory.cpp 438846c 
>   words/part/KWGui.cpp 69d309b 
> 
> Diff: http://git.reviewboard.kde.org/r/102871/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> screentshot of the new ui
>   http://git.reviewboard.kde.org/r/102871/s/306/
> toolbox in karbon
>   http://git.reviewboard.kde.org/r/102871/s/307/
> toolbox in krita
>   http://git.reviewboard.kde.org/r/102871/s/308/
> toolbox in stage
>   http://git.reviewboard.kde.org/r/102871/s/309/
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111017/283fd13b/attachment.htm>