Review Request: Fix loading/saving clone layers

[Torio Mlshi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102896/
-----------------------------------------------------------

(Updated Oct. 16, 2011, 4:59 p.m.)


Review request for Calligra and Boudewijn Rempt.


Description
-------

This patch fixes saving and loading of clone layers. It adds uuid to KisBaseNode so that clone layers use it to store information about their targets, making sure to target required layer.

About compatibility:
All nodes get uuid on creation. So node will have uuid even if no one is provided in file (which overwrites if present). Clone layers also use old code if no copyfromuuid field. So old files should work fine.
And new files should also be loaded ok by old versions because no fields are removed and old fields (such as copyfrom) are still valid. Of course, old versions will open new files just as old ones and bug will still present there.


This addresses bug 283610.
    http://bugs.kde.org/show_bug.cgi?id=283610


Diffs
-----

  krita/image/kis_base_node.h 798bb06 
  krita/image/kis_base_node.cpp cccbee8 
  krita/image/kis_clone_layer.h 21e766e 
  krita/image/kis_clone_layer.cpp 050ef5f 
  krita/ui/kra/kis_kra_load_visitor.h 89bf501 
  krita/ui/kra/kis_kra_load_visitor.cpp d980ab0 
  krita/ui/kra/kis_kra_loader.cpp 5d3e5d5 
  krita/ui/kra/kis_kra_savexml_visitor.cpp ecee329 
  krita/ui/kra/kis_kra_tags.h a737ae3 

Diff: http://git.reviewboard.kde.org/r/102896/diff/diff


Testing
-------

Old files worked fine, as expected.


Thanks,

Torio Mlshi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111016/87486e57/attachment.htm>