Review Request: Add PDF support to KOConverter
Dan Leinir Turthra Jensen
admin at leinir.dk
Thu Oct 13 09:41:17 BST 2011
> On Oct. 12, 2011, 7:33 p.m., Jan Hambrecht wrote:
> > tools/converter/koconverter.cpp, lines 71-73
> > <http://git.reviewboard.kde.org/r/102837/diff/1/?file=38640#file38640line71>
> >
> > I think you should check for a null pointer before defererencing.
Done and done - i actually did before you noted it, but still, thanks for catching it :)
- Dan Leinir Turthra
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102837/#review7277
-----------------------------------------------------------
On Oct. 12, 2011, 2:21 p.m., Dan Leinir Turthra Jensen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102837/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2011, 2:21 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> As subject indicates. Using the pdf printing functionality, add support for converting documents to pdf using koconverter.
>
> Furthermore, though this patch does not include it (it pollutes the patch with too many extraneous lines), this also changes the application binary name from koconverter to calligraconverter.
>
>
> Diffs
> -----
>
> tools/converter/CMakeLists.txt d3fee33
> tools/converter/koconverter.cpp abf2a58
>
> Diff: http://git.reviewboard.kde.org/r/102837/diff/diff
>
>
> Testing
> -------
>
> Testing with various documents, all converting accurately to pdf format
>
>
> Thanks,
>
> Dan Leinir Turthra Jensen
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111013/0de32256/attachment.htm>
More information about the calligra-devel
mailing list