reviewboard hates me

Boudewijn Rempt boud at valdyas.org
Sat Oct 1 08:58:50 BST 2011


It doesn't want to accept this patch, which I think needs at least a quick eyeballing from others. Please find it attached.

It's about splitting KoResourceManager:


KoResourceManager was used in two places: the canvas and document
classes. This gave rise to endless confusion about which resource
manager should be used where and contains what. The KoResourceManager
api also contained methods that were only relevant when used from
a document and others that were only relevant when used from a canvas.

This patch splits the resourcemanager into two public and one private
class. The public classes are KoDocumentResourceManager and
KoCanvasResourceManager, the private class is KoResourceManager. The
public classes defer to the private class for code-sharing purposes.

The old KoCanvasResource and KoDocumentResource enums have been taken
into the classes themselves.

-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Separate-KoResourceManager-for-canvas-and-document.patch
Type: text/x-patch
Size: 327471 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111001/8b2d925f/attachment.bin>


More information about the calligra-devel mailing list