Review Request: some warnings from clang++

[Sebastian Sauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103171/#review8279
-----------------------------------------------------------

Ship it!


The error in rtf-qt was fixed in master already ( http://bazaar.launchpad.net/~bradh/rtf-qt/trunk/view/head:/src/UserPropsDestination.cpp ) so not need to (re-)port/patch downstream.

- Sebastian Sauer


On Nov. 17, 2011, 6:43 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103171/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2011, 6:43 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> I'm still not able to compile calligra with clang 2.99.9999, but some meaningful warnings are produced.
> Instead of doing a comparation and loose the result, set the value.
> Return 0 (as nullptr) instead of false.
> 
> 
> Diffs
> -----
> 
>   filters/words/rtf/import/rtf-qt/src/UserPropsDestination.cpp 4e6d185 
>   plan/libs/models/kptnodeitemmodel.cpp 1ecb9f4 
> 
> Diff: http://git.reviewboard.kde.org/r/103171/diff/diff
> 
> 
> Testing
> -------
> 
> still compiles with g++
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111117/0bed16e1/attachment.htm>