Review Request: some warnings from clang++

Jaime Torres Amate jtamate at gmail.com
Thu Nov 17 18:43:24 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103171/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

I'm still not able to compile calligra with clang 2.99.9999, but some meaningful warnings are produced.
Instead of doing a comparation and loose the result, set the value.
Return 0 (as nullptr) instead of false.


Diffs
-----

  filters/words/rtf/import/rtf-qt/src/UserPropsDestination.cpp 4e6d185 
  plan/libs/models/kptnodeitemmodel.cpp 1ecb9f4 

Diff: http://git.reviewboard.kde.org/r/103171/diff/diff


Testing
-------

still compiles with g++


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111117/fde3bdb7/attachment.htm>


More information about the calligra-devel mailing list