Review Request: Final border refactoring : remove KoTableBorderStyle totally

Pierre Ducroquet pinaraf at gmail.com
Sat Nov 12 10:05:05 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102998/
-----------------------------------------------------------

(Updated Nov. 12, 2011, 10:05 a.m.)


Review request for Calligra.


Changes
-------

Update the patch :
- fix inheriting borders
- huge cleanup of KoBorder
- fix conflicting properties ids that were causing random issues


Description
-------

This ends the refactoring of KoTable*Style : now we got rid of KoTableBorderStyle and lots of code duplication.


Diffs (updated)
-----

  libs/kotext/CMakeLists.txt 03fd3dc 
  libs/kotext/KoTextDebug.cpp b492f2a 
  libs/kotext/opendocument/tests/TestLoading.cpp c4b6eda 
  libs/kotext/styles/KoTableBorderStyle.h 8a03ff2 
  libs/kotext/styles/KoTableCellStyle.h 6206658 
  libs/kotext/styles/KoTableCellStyle.cpp 98a9e76 
  libs/kotext/styles/tests/TestTableCellStyle.cpp 9da63aa 
  libs/odf/KoBorder.h 7fb3f33 
  libs/odf/KoBorder.cpp 61d1dcf 
  libs/textlayout/KoTextLayoutCellHelper.cpp f1eb7fa 

Diff: http://git.reviewboard.kde.org/r/102998/diff/diff


Testing
-------


Thanks,

Pierre Ducroquet

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111112/bd1cd9e0/attachment.htm>


More information about the calligra-devel mailing list