Review Request: Partly fixed rect position returned to input method through TextTool::InputMethodQuery.

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103091/#review8037
-----------------------------------------------------------


If you use the words part of my previous request, i think it will wor in Words too


libs/flake/KoCanvasController.h
<http://git.reviewboard.kde.org/r/103091/#comment6926>

    while you are at it please remove theses spaces too


- C. Boemann


On Nov. 9, 2011, 8:57 a.m., Yue Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103091/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2011, 8:57 a.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> Partly fixed rect position returned to input method through TextTool::InputMethodQuery. But still some problems.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoCanvasController.h 97a3e92 
>   libs/kopageapp/KoPACanvas.cpp 17dec46 
>   plugins/textshape/TextTool.cpp e699319 
> 
> Diff: http://git.reviewboard.kde.org/r/103091/diff/diff
> 
> 
> Testing
> -------
> 
> repeat pressing space key does not work, it only work once, strange.
> while pressing a key when im is enabled, caretRect() return position 0 so wrong rect is returned, no clue why it goes that way.
> in words an vertical offset is accumulated through pages.
> works in other apps, krita crashes due to other issues so haven't tested on it.
> 
> 
> Thanks,
> 
> Yue Liu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111109/867ea758/attachment.htm>