Review Request: Style inheritance
Pierre Ducroquet
pinaraf at gmail.com
Mon Nov 7 23:49:42 GMT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103017/#review8012
-----------------------------------------------------------
I won't comment on pure-coding issues as everybody else found, I guess, what could possibly be found…
I don't see major issues with these changes, I'm only really surprised that the saving code isn't more affected by this change. Did you try some round-tripping ?
Anyway, it all seems good to me.
- Pierre Ducroquet
On Nov. 7, 2011, 5:33 p.m., C. Boemann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103017/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2011, 5:33 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Fix inheritance in paragraph styles
> introduce inheritance in character styles
>
>
> Diffs
> -----
>
> libs/kotext/KoTextDebug.cpp 45df678
> libs/kotext/KoTextEditor.cpp 91dc334
> libs/kotext/opendocument/KoTextLoader.cpp fc7b764
> libs/kotext/opendocument/KoTextSharedLoadingData.h 320db92
> libs/kotext/opendocument/KoTextSharedLoadingData.cpp c1991bc
> libs/kotext/opendocument/KoTextWriter_p.cpp e9f1414
> libs/kotext/opendocument/tests/TestLoadStyle.cpp 37d39fd
> libs/kotext/opendocument/tests/TestLoading.cpp 222fb81
> libs/kotext/styles/KoCharacterStyle.h 53e98a1
> libs/kotext/styles/KoCharacterStyle.cpp 665e066
> libs/kotext/styles/KoListLevelProperties.cpp 4a35398
> libs/kotext/styles/KoListStyle.h aadeb0f
> libs/kotext/styles/KoParagraphStyle.h 3f9f40c
> libs/kotext/styles/KoParagraphStyle.cpp cdf16a4
> libs/kotext/styles/KoStyleManager.h ac145f9
> libs/kotext/styles/KoStyleManager.cpp fbbc4ee
> libs/kotext/styles/KoTableCellStyle.h 9ba0c3a
> libs/kotext/styles/KoTableCellStyle.cpp eb96cf9
> libs/kotext/styles/KoTableCellStyle_p.h c38556b
> libs/kotext/styles/tests/TestOpenDocumentStyle.cpp be46779
> libs/kotext/styles/tests/TestStyles.cpp ea7a434
> libs/textlayout/KoTextLayoutArea.cpp 28e4141
> plugins/chartshape/Axis.cpp d2a82ba
> plugins/textshape/TextShape.cpp cbd9593
> plugins/textshape/TextTool.cpp e699319
> plugins/textshape/dialogs/StyleManager.cpp 6110044
> plugins/textshape/dialogs/StylesModel.cpp 168ef715
> tables/Cell.cpp 378fa03
> tables/Map.cpp 956b3e1
> words/part/KWDocument.cpp 1941d7a
>
> Diff: http://git.reviewboard.kde.org/r/103017/diff/diff
>
>
> Testing
> -------
>
> cstester, show some improvements and some regressions
>
>
> Thanks,
>
> C. Boemann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111107/d172f7b7/attachment.htm>
More information about the calligra-devel
mailing list