Review Request: Change KoImageSelectionWidget to no longer embed a KFileWidget
C. Boemann
cbr at boemann.dk
Wed Nov 2 09:16:42 GMT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100716/#review7863
-----------------------------------------------------------
Hi i removed this class completely now, so please close the review
- C. Boemann
On Feb. 23, 2011, 11:48 p.m., Marijn Kruisselbrink wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100716/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2011, 11:48 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> This changes KoImageSelectionWidget to no longer be a widget that embeds a KFileWidget, but instead show a KFileDialog to select a file. This should make it for example feel more native when run on windows, as you get a real file dialog. The overall behavior of the widget hasn't really changed with this diff, after selecting a file in the dialog/widget, you still get a preview of the image and can Ok/Cancel it.
>
>
> Diffs
> -----
>
> libs/main/KoImageSelectionWidget.h 737ffdc3f655eaffb31eeb569384fe2b6c8aa678
> libs/main/KoImageSelectionWidget.cpp 92c6d215b1a4c30607b1855dd517cfbce61bdda7
>
> Diff: http://git.reviewboard.kde.org/r/100716/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marijn Kruisselbrink
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111102/a4c5dba3/attachment.htm>
More information about the calligra-devel
mailing list