Review Request: Fix clone layers updating
Torio Mlshi
mlshi at lavabit.com
Tue Nov 1 19:25:57 GMT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103021/
-----------------------------------------------------------
(Updated Nov. 1, 2011, 7:25 p.m.)
Review request for Calligra.
Summary (updated)
-----------------
Fix clone layers updating
Description
-------
This patch fixes issues, when clone layer wasn't updating despite its original was changed.
KisNode::setDirty now calls setDirty of parent to let its clones know about update. In MoveStrokeStrategy updating is now implemented via setDirty, so clone layers will know about update.
Diffs
-----
krita/image/kis_node.cpp 52881e7
krita/plugins/tools/defaulttools/strokes/move_stroke_strategy.cpp df8b6da
Diff: http://git.reviewboard.kde.org/r/103021/diff/diff
Testing
-------
Normal moving (when no clones) seems to have the same performance. Of course, performance becomes low when many clones are involved.
Unit tests have same results for me.
Thanks,
Torio Mlshi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111101/0b34ce9b/attachment.htm>
More information about the calligra-devel
mailing list