Review Request: Final border refactoring : remove KoTableBorderStyle totally

[Pierre Ducroquet]

> On Nov. 1, 2011, 11:10 a.m., Sebastian Sauer wrote:
> > libs/kotext/styles/KoTableCellStyle.cpp, line 1180
> > <http://git.reviewboard.kde.org/r/102998/diff/1/?file=39885#file39885line1180>
> >
> >     Just curious; is that correct? I mean top-right-bottom-left != bottom-left-top-right or?
> >

Yeah that's correct… Different naming used accross Calligra, that's to be fixed…


> On Nov. 1, 2011, 11:10 a.m., Sebastian Sauer wrote:
> > libs/kotext/opendocument/tests/TestLoading.cpp, line 400
> > <http://git.reviewboard.kde.org/r/102998/diff/1/?file=39882#file39882line400>
> >
> >     hmmm... why commenting that part of the test out rather then adopting so the tested cases are continued to be tested after the patch too?

It's because I've never managed to really use and understand that unit test, making testing of it unreliable. I'll try anyway.


- Pierre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102998/#review7793
-----------------------------------------------------------


On Oct. 30, 2011, 10:49 p.m., Pierre Ducroquet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102998/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2011, 10:49 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This ends the refactoring of KoTable*Style : now we got rid of KoTableBorderStyle and lots of code duplication.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/CMakeLists.txt 03fd3dc 
>   libs/kotext/KoTextDebug.cpp 45df678 
>   libs/kotext/opendocument/tests/TestLoading.cpp 222fb81 
>   libs/kotext/styles/KoTableBorderStyle.h 8a03ff2 
>   libs/kotext/styles/KoTableCellStyle.h f42c2a8 
>   libs/kotext/styles/KoTableCellStyle.cpp eb96cf9 
>   libs/kotext/styles/tests/TestTableCellStyle.cpp 9da63aa 
>   libs/textlayout/KoTextLayoutCellHelper.cpp f1eb7fa 
> 
> Diff: http://git.reviewboard.kde.org/r/102998/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pierre Ducroquet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20111101/f5f3a2e8/attachment.htm>