Review Request: Review request for the new branch "krita_resource-management-tagging-tiyyagura" under calligra repository

Sun May 29 17:09:25 BST 2011

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101467/#review3577
-----------------------------------------------------------

I'll leave comments on what the patch does to boud/slangkamp, but here's some whitespace/indenting issues.

krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp
<http://git.reviewboard.kde.org/r/101467/#comment2974>

    remove spaces around knsrcFile

krita/ui/widgets/kis_gradient_chooser.cc
<http://git.reviewboard.kde.org/r/101467/#comment2975>

    remove space around knsrcFile

krita/ui/widgets/kis_pattern_chooser.cc
<http://git.reviewboard.kde.org/r/101467/#comment2976>

    remove space around knsrcFile

krita/ui/widgets/kis_preset_chooser.cpp
<http://git.reviewboard.kde.org/r/101467/#comment2977>

    remove space around knsrcFile

libs/widgets/KoResourceItemChooser.h
<http://git.reviewboard.kde.org/r/101467/#comment2978>

    remove space around const QString& knsrcFileArg

libs/widgets/KoResourceItemChooser.cpp
<http://git.reviewboard.kde.org/r/101467/#comment2979>

    remove space around "document-open"

libs/widgets/KoResourceItemChooser.cpp
<http://git.reviewboard.kde.org/r/101467/#comment2980>

    remove spaces

libs/widgets/KoResourceItemChooser.cpp
<http://git.reviewboard.kde.org/r/101467/#comment2981>

    remove spaces

libs/widgets/KoResourceItemChooser.cpp
<http://git.reviewboard.kde.org/r/101467/#comment2982>

    remove spaces

libs/widgets/KoResourceItemChooser.cpp
<http://git.reviewboard.kde.org/r/101467/#comment2983>

    remove spaces

libs/widgets/KoResourceItemChooser.cpp
<http://git.reviewboard.kde.org/r/101467/#comment2984>

    remove space

libs/widgets/KoResourceItemChooser.cpp
<http://git.reviewboard.kde.org/r/101467/#comment2985>

    remove spaces

libs/widgets/KoResourceItemChooser.cpp
<http://git.reviewboard.kde.org/r/101467/#comment2986>

    remove spaces

libs/widgets/KoResourceItemChooser.cpp
<http://git.reviewboard.kde.org/r/101467/#comment2987>

    remove spaces

libs/widgets/KoResourceItemChooser.cpp
<http://git.reviewboard.kde.org/r/101467/#comment2988>

    remove spaces

libs/widgets/KoResourceItemChooser.cpp
<http://git.reviewboard.kde.org/r/101467/#comment2989>

    remove spaces

libs/widgets/KoResourceItemChooser.cpp
<http://git.reviewboard.kde.org/r/101467/#comment2990>

    remove spaces

libs/widgets/KoResourceItemChooser.cpp
<http://git.reviewboard.kde.org/r/101467/#comment2991>

    remove spaces

libs/widgets/KoResourceItemChooser.cpp
<http://git.reviewboard.kde.org/r/101467/#comment2992>

    remove spaces

libs/widgets/KoResourceServer.h
<http://git.reviewboard.kde.org/r/101467/#comment2993>

    remove spaces

libs/widgets/KoResourceServer.h
<http://git.reviewboard.kde.org/r/101467/#comment2994>

    remove spaces

libs/widgets/KoResourceServer.h
<http://git.reviewboard.kde.org/r/101467/#comment2995>

    remove spaces, and opening '{' should be on next line.

libs/widgets/KoResourceServer.h
<http://git.reviewboard.kde.org/r/101467/#comment2996>

    remove spaces

libs/widgets/KoResourceServer.h
<http://git.reviewboard.kde.org/r/101467/#comment2997>

    remove spaces

libs/widgets/KoResourceServer.h
<http://git.reviewboard.kde.org/r/101467/#comment2998>

    missing space after "if" and after ')'.

libs/widgets/KoResourceServer.h
<http://git.reviewboard.kde.org/r/101467/#comment2999>

    wrong indentation, remove one space.

libs/widgets/KoResourceServer.h
<http://git.reviewboard.kde.org/r/101467/#comment3000>

    missing space after "if"

libs/widgets/KoResourceServer.h
<http://git.reviewboard.kde.org/r/101467/#comment3001>

    remove spaces

libs/widgets/KoResourceServer.h
<http://git.reviewboard.kde.org/r/101467/#comment3002>

    remove spaces

libs/widgets/KoResourceServer.h
<http://git.reviewboard.kde.org/r/101467/#comment3003>

    remove spaces

libs/widgets/KoResourceServer.h
<http://git.reviewboard.kde.org/r/101467/#comment3004>

    remove spaces

libs/widgets/KoResourceServerAdapter.h
<http://git.reviewboard.kde.org/r/101467/#comment3005>

    remove spaces

libs/widgets/KoResourceServerAdapter.h
<http://git.reviewboard.kde.org/r/101467/#comment3006>

    remove spaces

libs/widgets/KoResourceServerAdapter.h
<http://git.reviewboard.kde.org/r/101467/#comment3007>

    remove spaces

libs/widgets/KoResourceServerAdapter.h
<http://git.reviewboard.kde.org/r/101467/#comment3008>

    remove spaces

libs/widgets/KoResourceServerAdapter.h
<http://git.reviewboard.kde.org/r/101467/#comment3009>

    remove spaces

libs/widgets/KoResourceServerAdapter.h
<http://git.reviewboard.kde.org/r/101467/#comment3010>

    remove spaces, and missing space after "if", and always put '{' and '}' around if blocks, even if just one line.

libs/widgets/KoResourceServerProvider.cpp
<http://git.reviewboard.kde.org/r/101467/#comment3011>

    missing space after "if" and before '{'.

libs/widgets/KoResourceServerProvider.cpp
<http://git.reviewboard.kde.org/r/101467/#comment3012>

    missing space after "foreach", remove space after opening '(' and insert space after opening '{'.

libs/widgets/KoResourceServerProvider.cpp
<http://git.reviewboard.kde.org/r/101467/#comment3013>

    missing space after "if" and before opening '{'.

- Elvis

On May 29, 2011, 3:48 p.m., Srikanth Tiyyagura wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101467/
> -----------------------------------------------------------
> 
> (Updated May 29, 2011, 3:48 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Review request for the branch krita_resource-management-tagging-tiyyagura under calligra repository
> 
> I want to merge this branch into master. Before that, I want to review it first. I already tried to post this review using post-review but it is giving error like this 
> 
>  File "/usr/lib/python2.7/httplib.py", line 809, in _send_output
>     msg += message_body
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc5 in position 44353: ordinal not in range(128)
> 
> So, I created a diff file between master and krita_resource-management-tagging-tiyyagura branch using the following command and posting that diff file
> 
> git diff master krita_resource-management-tagging-tiyyagura 
> 
> I didn't know whether this way is correct or wrong ? If it is wrong, please intimate me with correct procedure.
> 
> 
> Diffs
> -----
> 
>   krita/data/CMakeLists.txt 4b07140 
>   krita/data/kritabrushes.knsrc PRE-CREATION 
>   krita/data/kritagradients.knsrc PRE-CREATION 
>   krita/data/kritapatterns.knsrc PRE-CREATION 
>   krita/data/kritapresets.knsrc PRE-CREATION 
>   krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp 55efdec 
>   krita/ui/kis_paintop_box.cc aeebcae 
>   krita/ui/widgets/kis_gradient_chooser.cc 86ecfdf 
>   krita/ui/widgets/kis_pattern_chooser.cc 5b6661b 
>   krita/ui/widgets/kis_preset_chooser.cpp c0da30d 
>   libs/widgets/KoResourceItemChooser.h eee16cb 
>   libs/widgets/KoResourceItemChooser.cpp 03cd55c 
>   libs/widgets/KoResourceModel.cpp b007740 
>   libs/widgets/KoResourceServer.h cd9e42b 
>   libs/widgets/KoResourceServerAdapter.h dacc12f 
>   libs/widgets/KoResourceServerProvider.cpp 27f2203 
> 
> Diff: http://git.reviewboard.kde.org/r/101467/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110529/f5f7f7c9/attachment.htm>