Review-request: Fix copy+paste sections (bug 271029)

Boudewijn Rempt boud at valdyas.org
Thu May 26 09:06:32 BST 2011


On Thursday 26 May 2011 May, Sebastian Sauer wrote:
> The problem is that on copy+paste text in Words we create ODF ouf of a 
> fragment. That fragment can contains SectionEnd's without SectionStart's (or 
> the other way around which would probably produce invalid XML? That case is 
> not handled with this patch :-/ ). That results then in an assert. See bug 
> 271029 for more details.

I'm not really deep into section handling -- I think there might be more issues around than just these. But it looks like a good patch to me.

> 
> Attached patch fixes the assert with the document attached to the bugreport. 
> But I am not sure if it's complete cause, as I wrote above, we need to take 
> also the inverse case into account somehow and I am atm not sure how. Maybe we 
> can just write endElement()'s till the styleStack isEmpty or so?
> 

I don't know...

-- 
Boudewijn Rempt | http://www.valdyas.org, http://www.krita.org



More information about the calligra-devel mailing list