Review Request: Add libkundo2 to Calligra

Alexander Potashev aspotashev at gmail.com
Sun May 22 13:17:39 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101414/
-----------------------------------------------------------

Review request for Calligra.


Summary
-------

kundo2 is a fork of Qt's Undo Framework (QUndoStack, QUndoView, ...).
It contains two bugfixes the are going to be available only in Qt 4.8:
	https://qt.gitorious.org/qt/qt/merge_requests/1212
	https://qt.gitorious.org/qt/qt/merge_requests/2610

To start using kundo2, one should port Calligra to it. This can be done
by adding target_link_libraries(... kundo2) into CMakeLists.txt files
for all modules from Calligra that use Qt Undo Framework, and by
switching from QUndo**** classes to KUndo2**** classes.
(switching to KUndo2 classes can easily be done by using a script)
Script for forward and backward porting: https://github.com/aspotashev/libkundo2/blob/master/port-kundo2.sh

After Calligra starts requiring Qt 4.8+, this library can be removed,
because it has no advantages over Qt's Undo Framework 4.8.


Diffs
-----

  libs/CMakeLists.txt 6179f0a 
  libs/kundo2/CMakeLists.txt PRE-CREATION 
  libs/kundo2/kundo2_export.h PRE-CREATION 
  libs/kundo2/kundo2command.h PRE-CREATION 
  libs/kundo2/kundo2group.h PRE-CREATION 
  libs/kundo2/kundo2group.cpp PRE-CREATION 
  libs/kundo2/kundo2model.h PRE-CREATION 
  libs/kundo2/kundo2model.cpp PRE-CREATION 
  libs/kundo2/kundo2qstack.h PRE-CREATION 
  libs/kundo2/kundo2stack.h PRE-CREATION 
  libs/kundo2/kundo2stack.cpp PRE-CREATION 
  libs/kundo2/kundo2stack_p.h PRE-CREATION 
  libs/kundo2/kundo2view.h PRE-CREATION 
  libs/kundo2/kundo2view.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/101414/diff


Testing
-------

It compiles.


Thanks,

Alexander

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110522/d5f4a536/attachment.htm>


More information about the calligra-devel mailing list