[calligra] plugins/chartshape: added a better CellRangeParser

Boudewijn Rempt boud at valdyas.org
Thu May 19 14:24:13 BST 2011


On Wednesday 18 May 2011 May, Cyrille Berger Skott wrote:
> Hi,
> 
> Looks like this commits is breaking a handfull of kchart tests:
> 
> http://my.cdash.org/viewTest.php?onlyfailed&buildid=188934
> 

Yes... Our unittest situation is _bad_ now. I think we should seriously start considering having a no-questions-ask-if-it-breaks-a-test-it-gets-reverted policy. Because we really should _stop_ breaking unittests (or disabling unittests, or removing unittests without adding a replacement).

I get this now:

The following tests FAILED:
         23 - kspread-Formula (Failed)
         54 - krita-image-KisIteratorTest (Failed)
         55 - krita-image-KisPainterTest (Failed)
        107 - krita-image-KisPaintopSettingsTest (Failed)
        169 - krita-ui-kis_exr_test (Failed)
        171 - krita-plugin-format-xcf_test (Failed)
        197 - libs-kotext-styles-TestOpenDocumentStyle (Failed)
        199 - kotext-odf-TestLoading (Timeout)
        200 - kotext-odf-TestChangeTracking (Failed)
        214 - libs-flake-TestShapeGroupCommand (Failed)
        225 - libs-flake-TestSnapStrategy (Failed)
        234 - libs-pigment-TestKoRgbU8ColorSpaceTester (Failed)
        235 - libs-pigment-TestKoCompositeOps (Failed)
        255 - kchart-TestProxyModel (Failed)
        259 - kchart-TestCellRegion (Failed)
        260 - kchart-TestLoading-default-ooo-chart (Failed)
        261 - kchart-TestLoading-bug239802 (Failed)
        262 - kchart-TestLoading-default-koffice-chart (Failed)
        263 - kchart-TestLoading-bubble-chart (Failed)
        265 - kspread-xlsx-FormulaParser (Failed)

-- 
Boudewijn Rempt | http://www.valdyas.org, http://www.krita.org



More information about the calligra-devel mailing list