Review Request: Add support for style:wrap-dynamic-threshold

Elvis Stansvik elvstone at gmail.com
Sat May 14 15:49:56 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101361/
-----------------------------------------------------------

Review request for Calligra and Casper Boemann.


Summary
-------

This patch adds support for style:wrap-dynamic-threshold [1], allowing the user to specify a threshold when dynamic wrap (a.k.a. EnoughRunAroundSide in KoShape API) is used. See the UI screenshot.


Diffs
-----

  libs/flake/KoShape.h 99e185b 
  libs/flake/KoShape.cpp dd8e91c 
  libs/flake/KoShape_p.h 428304d 
  libs/textlayout/KoTextLayoutObstruction.h 1b81492 
  libs/textlayout/KoTextLayoutObstruction.cpp 323ba360 
  libs/textlayout/RunAroundHelper.cpp c318d4a 
  words/part/dialogs/KWRunAroundProperties.h c23bf36 
  words/part/dialogs/KWRunAroundProperties.cpp a6ea6d0 
  words/part/dialogs/KWRunAroundProperties.ui d1ce389 

Diff: http://git.reviewboard.kde.org/r/101361/diff


Testing
-------

I tried adding some lorem ipsum text and a picture and activate the option. Works as expected. Did a save/load roundtrip and everything looks good.


Screenshots
-----------

The UI of the feature.
  http://git.reviewboard.kde.org/r/101361/s/168/


Thanks,

Elvis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110514/113409d8/attachment.htm>


More information about the calligra-devel mailing list