Review Request: Make Calligra able to load foo.doc that really contains a docx file, and similar for xls and ppt.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101271/#review3057
-----------------------------------------------------------



libs/main/KoDocument.cpp
<http://git.reviewboard.kde.org/r/101271/#comment2615>

    Oh, I hadn't seen that the list includes the result of "findByFileContents" already.
    
    
    But then why these additional ifs here? Isn't this covered by the list?
    
    At least for xls and ppt, you should get reliable results from findByUrl, so testing this again with fiename.endsWith() seems redundant.
    (Note that .doc is different; the extension doesn't imply msword, because linux has .doc plain text files).


- David


On May 2, 2011, 1:40 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101271/
> -----------------------------------------------------------
> 
> (Updated May 2, 2011, 1:40 p.m.)
> 
> 
> Review request for Calligra and David Faure.
> 
> 
> Summary
> -------
> 
> Lately, a lot of document has been cropping up that have names like foo.doc but that really are docx files inside.  Similar goes for xls/xlsx and ppt/pptx. This patch handles this case by not just using the name for determining the mimetype of the file while loading, but also looking at the contents (KMimeType:findByContents). It also introduces a replacement scheme to take care of reported mimetypes like application/zip instead of, say, docx.
> 
> 
> Diffs
> -----
> 
>   krita/plugins/filters/fastcolortransfer/fastcolortransfer.cpp fc94465 
>   krita/sdk/tests/filestest.h ef6f0f0 
>   krita/ui/kis_import_catcher.cc 8c2c42a 
>   libs/main/KoDocument.cpp 1ed2052 
>   libs/main/KoFilterManager.h fc7731c 
>   libs/main/KoFilterManager.cpp f840f69 
> 
> Diff: http://git.reviewboard.kde.org/r/101271/diff
> 
> 
> Testing
> -------
> 
> This patch is tested on all combinations of doc/docx, ppt/pptx and xls/xlsx as well as on files containing the actual format that the names suggest.
> 
> 
> Thanks,
> 
> Inge
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110502/fdac6ee3/attachment.htm>