Review Request: Share handle radius and grab sensitivity via the document resource

[Boudewijn Rempt]

On Saturday 26 March 2011 Mar, jaham at gmx.net wrote:
> On Saturday 26 March 2011 12:20:34 Boudewijn Rempt wrote:
> > On Saturday 26 March 2011 Mar, jaham at gmx.net wrote:
> > > On Friday 25 March 2011 11:48:15 Boudewijn Rempt wrote:
> > > > On Thursday 24 March 2011 Mar, jaham at gmx.net wrote:
> > > > > On Thursday 24 March 2011 10:01:37 Boudewijn Rempt wrote:
> > > > > > On Wednesday 23 March 2011 Mar, Jan Hambrecht wrote:
> > > > > > > This patch changes the scope of the handle radius and grab
> > > > > > > sensitivity settings from the canvas resource to the document
> > > > > > > resource. I also added some convenience functions to KoToolBase
> > > > > > > and KoInteractionStrategy so that users of these settings do not
> > > > > > > need to know from which resource manager to pulle these
> > > > > > > settings. This fixes changing both settings from the shared
> > > > > > > config page used in karbon, kpresenter and flow.
> > > > > > 
> > > > > > Hm... I'm not sure I ever understood why these settings were
> > > > > > per-canvas, but is per document better? Maybe they can just be
> > > > > > completely global settings, valid for all canvases and all
> > > > > > documents?
> > > > > 
> > > > > Isn't that equivalent to what i did as all our apps are single
> > > > > document anyway?
> > > > 
> > > > I'm feeling sort of confused now -- we can open more than one document,
> > > > right? So we could have different settings in different windows in the
> > > > same app?
> > > 
> > > Hm, yes you are right. But then I don't know where to best put these
> > > settings so that there are accessible from tools. Any suggestions?
> > 
> > Can't we just use kconfig?
> 
> That would be nice in theory. But while working on the patch to improve the 
> pasting behaviour, I learned that the kconfig data of two different 
> kcomponentdata objects are not synced with each other. So it would be the same 
> situation as of with this current patch. That means each of the opened kparts 
> of the application would have their own independent settings, and the last one 
> closed would write them back to the config file.
> 

Meh... Then I think there's no other solution but to go with your original patch.

-- 
Boudewijn Rempt | http://www.valdyas.org, http://www.krita.org