Review Request: Lists bug fixes and enhancement

Lukáš Tvrdý lukast.dev at gmail.com
Fri Mar 25 18:05:04 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100918/#review2174
-----------------------------------------------------------


It looks ok to me. I tested the document in the bug report.
I had some problem with the square bullet character on the slide 4.
Probably some local font issue as it worked for Gopak.

Uzak will look at this too later as he needs more time for this.



libs/kotext/styles/KoCharacterStyle.cpp
<http://git.reviewboard.kde.org/r/100918/#comment1798>

    Not sure why there is semicolumn and then + here? Probably you intend to do something different.



libs/kotext/styles/KoListStyle.h
<http://git.reviewboard.kde.org/r/100918/#comment1799>

    Why removing this QTextListFormat::ListDisc and why not using it later?


- Lukáš


On March 24, 2011, 4:20 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100918/
> -----------------------------------------------------------
> 
> (Updated March 24, 2011, 4:20 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Fixes the following problems in list rendering
> 1)The type of list item was not shown in the paragraph docker(SimpleParagraphWidget).
> 2)Takes into account the font-size percent while loading and saving lists.
> 3) Prefixes and suffixes are now displayed for bulleted lists.
> 
> 
> This addresses bug 264143.
>     http://bugs.kde.org/show_bug.cgi?id=264143
> 
> 
> Diffs
> -----
> 
>   filters/words/oowriter/oowriterimport.cc 2bd55ee 
>   libs/kotext/styles/KoCharacterStyle.h 3cec793 
>   libs/kotext/styles/KoCharacterStyle.cpp 6eaab0f 
>   libs/kotext/styles/KoListLevelProperties.h 14814fe 
>   libs/kotext/styles/KoListLevelProperties.cpp 62a5175 
>   libs/kotext/styles/KoListStyle.h bee4eaf 
>   libs/kotext/styles/KoListStyle.cpp 52d7c2f 
>   libs/odf/KoStyleStack.h 2f4d2cf 
>   libs/odf/KoStyleStack.cpp 491f14e 
>   plugins/textshape/ListItemsHelper.cpp aa61481 
>   plugins/textshape/TextShapeLayout.cpp ea49dc4 
>   plugins/textshape/commands/ChangeListCommand.cpp 23eeee0 
>   plugins/textshape/dialogs/ParagraphBulletsNumbers.cpp 14c5fd7 
>   plugins/textshape/tests/TestChangeListCommand.cpp 4da46d1 
>   plugins/textshape/tests/TestLists.cpp 316f5f6 
>   tools/mobile/ApplicationController.cpp 83ebe6e 
>   words/part/KWDLoader.cpp e99435a 
>   words/part/KWDocument.cpp 8408c42 
>   words/plugins/scripting/Style.h a72c0d2 
> 
> Diff: http://git.reviewboard.kde.org/r/100918/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/calligra-devel/attachments/20110325/95b7b04c/attachment.htm 


More information about the calligra-devel mailing list