Review Request: Share handle radius and grab sensitivity via the document resource

Jan Hambrecht jaham at gmx.net
Wed Mar 23 22:21:04 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100938/
-----------------------------------------------------------

Review request for Calligra.


Summary
-------

This patch changes the scope of the handle radius and grab sensitivity settings from the canvas resource to the document resource. I also added some convenience functions to KoToolBase and KoInteractionStrategy so that users of these settings do not need to know from which resource manager to pulle these settings. This fixes changing both settings from the shared config page used in karbon, kpresenter and flow.


Diffs
-----

  karbon/plugins/tools/KarbonGradientTool.cpp 44fe28b 
  karbon/plugins/tools/KarbonPatternTool.cpp 476787d 
  karbon/plugins/tools/KarbonPencilTool.cpp 2238fe4 
  karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsTool.cpp 8f7a40f 
  karbon/ui/KarbonPart.cpp 9c63c14 
  libs/flake/KoResourceManager.h bc93692 
  libs/flake/KoResourceManager.cpp da12bb5 
  libs/flake/KoShapeControllerBase.cpp 6352fd6 
  libs/flake/KoToolBase.h db16ac2 
  libs/flake/KoToolBase.cpp 52090a2 
  libs/flake/tools/KoCreatePathTool.cpp 884ea1f 
  libs/flake/tools/KoCreatePathTool_p.h a9b2ee6 
  libs/flake/tools/KoInteractionStrategy.h 2f45219 
  libs/flake/tools/KoInteractionStrategy.cpp a730c3d 
  libs/flake/tools/KoPathTool.cpp 6c38ca5 
  libs/flake/tools/KoPathToolHandle.h f11ea34 
  libs/flake/tools/KoPathToolHandle.cpp e5eea1f 
  libs/flake/tools/KoPathToolSelection.cpp 6372e8d 
  libs/main/config/KoConfigMiscPage.cpp 71140ca 
  plugins/defaultTools/connectionTool/ConnectionTool.cpp f19d256 
  plugins/defaultTools/connectionTool/MoveConnectionPointStrategy.cpp 582cdd7 
  plugins/defaultTools/defaulttool/DefaultTool.cpp 1e33ca4 
  plugins/defaultTools/defaulttool/ShapeMoveStrategy.cpp e0cc028 
  plugins/defaultTools/defaulttool/ShapeResizeStrategy.cpp 32cb211 
  plugins/defaultTools/defaulttool/ShapeRotateStrategy.cpp 30b8d84 
  plugins/defaultTools/defaulttool/ShapeShearStrategy.cpp f2ec9e1 
  plugins/defaultTools/guidestool/GuidesTool.cpp 631c61a 

Diff: http://git.reviewboard.kde.org/r/100938/diff


Testing
-------


Thanks,

Jan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110323/1175283d/attachment.htm>


More information about the calligra-devel mailing list