Review Request: Lists bug fixes and enhancement

[Casper Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100918/#review2102
-----------------------------------------------------------


Okay In general it looks nice. I'm however a bit worried since this is a very delicate, so I'm going to wait for others to comment as well.

Also the layout code is going to change, so in order to commit this I'll have to ask you to port the TextShape part to the new layout engine too, so we don't loose anything


filters/words/oowriter/oowriterimport.cc
<http://git.reviewboard.kde.org/r/100918/#comment1744>

    please use qreal instead of double



libs/kotext/styles/KoListLevelProperties.h
<http://git.reviewboard.kde.org/r/100918/#comment1745>

    


- Casper


On March 22, 2011, 3:04 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100918/
> -----------------------------------------------------------
> 
> (Updated March 22, 2011, 3:04 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Fixes the following problems in list rendering
> 1)The type of list item was not shown in the paragraph docker(SimpleParagraphWidget).
> 2)Takes into account the font-size percent while loading and saving lists.
> 3) Prefixes and suffixes are now displayed for bulleted lists.
> 
> 
> This addresses bug 264143.
>     http://bugs.kde.org/show_bug.cgi?id=264143
> 
> 
> Diffs
> -----
> 
>   filters/words/oowriter/oowriterimport.cc 2bd55ee 
>   libs/kotext/styles/KoCharacterStyle.h 3cec793 
>   libs/kotext/styles/KoCharacterStyle.cpp 6eaab0f 
>   libs/kotext/styles/KoListLevelProperties.h 14814fe 
>   libs/kotext/styles/KoListLevelProperties.cpp 62a5175 
>   libs/kotext/styles/KoListStyle.h bee4eaf 
>   libs/kotext/styles/KoListStyle.cpp 52d7c2f 
>   libs/odf/KoStyleStack.h 2f4d2cf 
>   libs/odf/KoStyleStack.cpp 491f14e 
>   plugins/textshape/ListItemsHelper.cpp aa61481 
>   plugins/textshape/TextShapeLayout.cpp ea49dc4 
>   plugins/textshape/commands/ChangeListCommand.cpp 23eeee0 
>   plugins/textshape/dialogs/ParagraphBulletsNumbers.cpp 14c5fd7 
>   plugins/textshape/tests/TestChangeListCommand.cpp 4da46d1 
>   plugins/textshape/tests/TestLists.cpp 316f5f6 
>   tools/f-office/ApplicationController.cpp e85a50a 
>   words/part/KWDLoader.cpp e99435a 
>   words/part/KWDocument.cpp 8408c42 
>   words/plugins/scripting/Style.h a72c0d2 
> 
> Diff: http://git.reviewboard.kde.org/r/100918/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110322/1f90caf1/attachment.htm>