Review Request: Extended Selection to Stages Slides Sorter

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100871/#review2091
-----------------------------------------------------------

Ship it!


Hello Paul,

nice work. Please fix the two comments I noted. If you want I can commit it for you but I think you should get a git account and then please commit your patch yourself. See: http://community.kde.org/Sysadmin/GitKdeOrgManual#How_to_get_read-write_developer_access for more information on the topic.


kpresenter/part/KPrViewModeSlidesSorter.h
<http://git.reviewboard.kde.org/r/100871/#comment1737>

    The comment should be updated to reflect the new interface.



kpresenter/part/KPrViewModeSlidesSorter.h
<http://git.reviewboard.kde.org/r/100871/#comment1736>

    Maybe this function should be renamed to movePages as it now makes it possible to move multiple pages at once.


- Thorsten


On March 20, 2011, 10:01 p.m., Paul Mendez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100871/
> -----------------------------------------------------------
> 
> (Updated March 20, 2011, 10:01 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Add extended selection to Stages Slide Sorter (drag & drop, copy, cut and paste multiple slides).
> 
> 
> Diffs
> -----
> 
>   kpresenter/part/KPrSlidesSorterDocumentModel.cpp 205ada94e44c00b11454026b8cab8688ccd74d48 
>   kpresenter/part/KPrViewModeSlidesSorter.h 37ef02c76b3fbc53ef8656aa0e5af4d908c95bc3 
>   kpresenter/part/KPrViewModeSlidesSorter.cpp db64e5552bf3681879040ecd219757a715e6a5fc 
> 
> Diff: http://git.reviewboard.kde.org/r/100871/diff
> 
> 
> Testing
> -------
> 
> Building and runing
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110322/d61f2ef4/attachment.htm>