Review Request: Paste shapes at cursor position

[Thorsten Zachmann]

> On March 20, 2011, 11:59 a.m., Thorsten Zachmann wrote:
> > Hello Jan,
> > 
> > when testing I found the following:
> > 
> > - After changing the setting it does not take effect before restarting the application.
> > - In flow and stage somehow the setting is not saved at all.
> > 
> > Is it wanted that the shape is placed with its center at the cursor?
> > 
> > Thorsten
> >
> 
> Jan Hambrecht wrote:
>     Yes, I noticed this problem too. But I think it is outside of the scope of this patch to fix that. (I only added to the code handling the settings which was already there).
>     And placing the shapes with their center at the cursor is intentional. Do you think of something different/better?

What do you think is outside of the scope of the patch to fix? For me at least -After changing the setting it does not take effect should be fixed. And I wanted to test the behaviour in stage, flow to see if it works with different canvas implementations correctly.

I would have guessed that the mouse would mark the top left corner as place where it gets inserted. But that is only what I have expected. But using the center is fine too.


- Thorsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100891/#review2057
-----------------------------------------------------------


On March 19, 2011, 8:30 p.m., Jan Hambrecht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100891/
> -----------------------------------------------------------
> 
> (Updated March 19, 2011, 8:30 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Patch provides an alternative way to position shapes when pasting them to the document. The new way allows shapes to be positioned at the position of the mouse cursor within the current canvas. Which behaviour is used can be configured via a shared config page.
> 
> 
> This addresses bug 129096.
>     http://bugs.kde.org/show_bug.cgi?id=129096
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShapePaste.cpp 3cb5d58 
>   libs/main/config/KoConfigMiscPage.cpp 8c1375c 
> 
> Diff: http://git.reviewboard.kde.org/r/100891/diff
> 
> 
> Testing
> -------
> 
> Yes, works like expected.
> 
> 
> Thanks,
> 
> Jan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110320/0fe50352/attachment.htm>