Review Request: Extended Selection to Stages Slides Sorter

Thorsten Zachmann t.zachmann at zagge.de
Sun Mar 20 12:07:48 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100871/#review2058
-----------------------------------------------------------


Hello Paul,

about the undo commands. At the moment when you move two slides at the same time 2 commands will be created. So to undo the move of 2 slides in one action you need to undo twice. This is not nice as only one action was done by the user. So also undoing should undo the move of both pages. There is a possibility to pass a parent command that groups all commands. I hope that answers your question.

Thorsten

- Thorsten


On March 19, 2011, 8:24 p.m., Paul Mendez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100871/
> -----------------------------------------------------------
> 
> (Updated March 19, 2011, 8:24 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Add extended selection to Stages Slide Sorter (drag & drop, copy, cut and paste multiple slides).
> 
> 
> Diffs
> -----
> 
>   kpresenter/part/KPrSlidesSorterDocumentModel.cpp 205ada94e44c00b11454026b8cab8688ccd74d48 
>   kpresenter/part/KPrViewModeSlidesSorter.h 37ef02c76b3fbc53ef8656aa0e5af4d908c95bc3 
>   kpresenter/part/KPrViewModeSlidesSorter.cpp db64e5552bf3681879040ecd219757a715e6a5fc 
> 
> Diff: http://git.reviewboard.kde.org/r/100871/diff
> 
> 
> Testing
> -------
> 
> Building and runing
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110320/3575ba90/attachment.htm>


More information about the calligra-devel mailing list