Review Request: Extended Selection to Stages Slides Sorter

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100871/#review2028
-----------------------------------------------------------


If multiple slides are copied it generated multiple undo commands. It would be nice if only one undo command would be generated.


kpresenter/part/KPrSlidesSorterDocumentModel.cpp
<http://git.reviewboard.kde.org/r/100871/#comment1694>

    there should be no blank after (



kpresenter/part/KPrViewModeSlidesSorter.h
<http://git.reviewboard.kde.org/r/100871/#comment1695>

    The function should return the slides istead passing as parameter



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100871/#comment1696>

    The { should be at the end of the previous line



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100871/#comment1697>

    The { should be at the end of the previous line



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100871/#comment1698>

    There should be a blank after ,



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100871/#comment1699>

    The { should be at the end of the previous line
    



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100871/#comment1700>

    The { should be at the end of the previous line



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100871/#comment1701>

    There should be a blank after the ,



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100871/#comment1704>

    Can be moved inside the if and be directly initialized by with the new. 



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100871/#comment1702>

    There should be no blank after (



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100871/#comment1703>

    The it can be moved inside the above if as it can only be true there


- Thorsten


On March 16, 2011, 2:50 a.m., Paul Mendez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100871/
> -----------------------------------------------------------
> 
> (Updated March 16, 2011, 2:50 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Add extended selection to Stages Slide Sorter (drag & drop, copy, cut and paste multiple slides).
> 
> 
> Diffs
> -----
> 
>   kpresenter/part/KPrSlidesSorterDocumentModel.cpp 205ada9 
>   kpresenter/part/KPrViewModeSlidesSorter.h 37ef02c 
>   kpresenter/part/KPrViewModeSlidesSorter.cpp db64e55 
> 
> Diff: http://git.reviewboard.kde.org/r/100871/diff
> 
> 
> Testing
> -------
> 
> Building and runing
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110318/10baa9d8/attachment.htm>