Review Request: Fixed autoscrolling bug in Krita

Dmitry Kazakov dimula73 at gmail.com
Sun Mar 13 18:40:53 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100851/
-----------------------------------------------------------

Review request for Calligra.


Summary
-------

This patch fixes an autoscrolling bug in Krita. It is caused by the differences between coordinate systems of Krita and flake. So I've extracted one method from KoToolProxy and overridden it in newly created KisToolProxy. This method just converts widget coordinates into document coordinates.

The changes in KoToolProxy do not change anything in it, but it would be better to test whether the other applications still work fine =)


This addresses bug 265528.
    http://bugs.kde.org/show_bug.cgi?id=265528


Diffs
-----

  krita/ui/CMakeLists.txt 5b702c5 
  krita/ui/canvas/kis_canvas2.cpp 3e4dc6c 
  krita/ui/canvas/kis_tool_proxy.h PRE-CREATION 
  krita/ui/canvas/kis_tool_proxy.cpp PRE-CREATION 
  libs/flake/KoToolProxy.h c5393f2 
  libs/flake/KoToolProxy.cpp 4f1608e 
  libs/flake/KoToolProxy_p.h 8baf4ac 

Diff: http://git.reviewboard.kde.org/r/100851/diff


Testing
-------


Thanks,

Dmitry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110313/a3e8eaf8/attachment.htm>


More information about the calligra-devel mailing list