Review Request: Support for svg like clipping for shapes
Jan Hambrecht
jaham at gmx.net
Sun Mar 13 00:23:19 GMT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100809/
-----------------------------------------------------------
(Updated March 13, 2011, 12:23 a.m.)
Review request for Calligra.
Changes
-------
I think i fixed all issues pointed out in the review so far.
Summary
-------
This patch implements clipping for shapes using arbitrary clipping paths. This is needed to properly support svg clipping.
There is a new class KoClipPath which can be set on a shape. The clipping path is then used when painting the shape to set the clipping path on the painter.
There are also two commands to set and to unset a clipping path on a shape.
Diffs (updated)
-----
filters/karbon/svg/CMakeLists.txt 2a89825
filters/karbon/svg/SvgClipPathHelper.h PRE-CREATION
filters/karbon/svg/SvgClipPathHelper.cpp PRE-CREATION
filters/karbon/svg/SvgGraphicContext.h dbb28ae
filters/karbon/svg/SvgParser.h c9a09b1
filters/karbon/svg/SvgParser.cpp 0372fde
filters/karbon/svg/svgexport.h 6689299
filters/karbon/svg/svgexport.cc 7627006
karbon/data/karbon.rc cf0a238
karbon/ui/KarbonView.h 235720f
karbon/ui/KarbonView.cpp c4e3603
libs/flake/CMakeLists.txt e153e14
libs/flake/KoClipPath.h PRE-CREATION
libs/flake/KoClipPath.cpp PRE-CREATION
libs/flake/KoShape.h b4b3033
libs/flake/KoShape.cpp c5f0fd9
libs/flake/KoShapeManager.cpp 7f225f9
libs/flake/KoShape_p.h 5874cbd
libs/flake/commands/KoShapeClipCommand.h PRE-CREATION
libs/flake/commands/KoShapeClipCommand.cpp PRE-CREATION
libs/flake/commands/KoShapeUnclipCommand.h PRE-CREATION
libs/flake/commands/KoShapeUnclipCommand.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/100809/diff
Testing
-------
Tested with svg files from the svg test suite as well as some kde icons like akregator.svgz (see bug 264411)
Thanks,
Jan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110313/3e293ca0/attachment.htm>
More information about the calligra-devel
mailing list