Review Request: Stage: Enhace behaviour of copy/paste slides in slide sorter

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100672/#review1759
-----------------------------------------------------------


Works nicely. You can commit after you fixed the comments I mentioned


kpresenter/part/KPrSlidesSorterDocumentModel.h
<http://git.reviewboard.kde.org/r/100672/#comment1446>

    You should put your copyright here.



kpresenter/part/KPrSlidesSorterDocumentModel.cpp
<http://git.reviewboard.kde.org/r/100672/#comment1447>

    You should put your copyright here.



kpresenter/part/KPrViewModeSlidesSorter.h
<http://git.reviewboard.kde.org/r/100672/#comment1448>

    Is this export really needed?



libs/kopageapp/CMakeLists.txt
<http://git.reviewboard.kde.org/r/100672/#comment1450>

    As far as I have seen you are not using the model somewhere so this change might not be needed



libs/kopageapp/KoPADocumentStructureDocker.cpp
<http://git.reviewboard.kde.org/r/100672/#comment1449>

    Is this a bug fix for a current problem?


- Thorsten


On March 3, 2011, 6:01 p.m., Paul Mendez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100672/
> -----------------------------------------------------------
> 
> (Updated March 3, 2011, 6:01 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Correct how slides sorter updates when add/delete/copy/paste a slide. Add some copy/paste extra context menu, and the supr key for delete slides in slides sorter.
> 
> Any suggestion for add Contrl C/V/X support?
> 
> 
> Diffs
> -----
> 
>   kpresenter/part/CMakeLists.txt 5dfdb1b 
>   kpresenter/part/KPrSlidesSorterDocumentModel.h e69de29 
>   kpresenter/part/KPrSlidesSorterDocumentModel.cpp e69de29 
>   kpresenter/part/KPrViewModeSlidesSorter.h 743fbe9 
>   kpresenter/part/KPrViewModeSlidesSorter.cpp 24e6c1e 
>   libs/kopageapp/CMakeLists.txt 3d72626 
>   libs/kopageapp/KoPADocumentStructureDocker.cpp 08fb66a 
>   libs/kopageapp/KoPAView.h 55a6b7d 
> 
> Diff: http://git.reviewboard.kde.org/r/100672/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110306/a5f6161e/attachment.htm>