Review Request: Stage: Enhace behaviour of copy/paste slides in slide sorter

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100672/#review1733
-----------------------------------------------------------


Sorry for not reviewing earlier. I will test it tomorrow.


kpresenter/part/KPrViewModeSlidesSorter.h
<http://git.reviewboard.kde.org/r/100672/#comment1419>

    there is already a model used in the document viewer. Maybe it is possible to reuse that here. If not it would be nice if you could move the class to its own file.



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100672/#comment1420>

    Please remove the blank at the end of the line



kpresenter/part/KPrViewModeSlidesSorter.cpp
<http://git.reviewboard.kde.org/r/100672/#comment1421>

    Strings should be inside a i18n("to translate") so that the strings are translated


- Thorsten


On Feb. 24, 2011, 4:19 p.m., Paul Mendez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100672/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2011, 4:19 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Correct how slides sorter updates when add/delete/copy/paste a slide. Add some copy/paste extra context menu, and the supr key for delete slides in slides sorter.
> 
> Any suggestion for add Contrl C/V/X support?
> 
> 
> Diffs
> -----
> 
>   kpresenter/part/KPrViewModeSlidesSorter.h 743fbe9 
>   kpresenter/part/KPrViewModeSlidesSorter.cpp 24e6c1e 
>   libs/kopageapp/KoPADocumentStructureDocker.cpp 08fb66a 
>   libs/kopageapp/KoPAView.h 55a6b7d 
> 
> Diff: http://git.reviewboard.kde.org/r/100672/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110302/fccd210d/attachment.htm>