Review Request: avoid some null pointers dereferences

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101796/#review4250
-----------------------------------------------------------

Ship it!


Thanks a bunch! Please fix the small niggle I noted about the coding style... Then commit.


filters/karbon/svg/SvgParser.cpp
<http://git.reviewboard.kde.org/r/101796/#comment3482>

    Mind the coding style... No space between ! and shape, and indent with four, not two spaces.



filters/tables/libkspreadexport/KSpreadLeader.cc
<http://git.reviewboard.kde.org/r/101796/#comment3483>

    Good catch!


- Boudewijn


On June 28, 2011, 6:16 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101796/
> -----------------------------------------------------------
> 
> (Updated June 28, 2011, 6:16 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> cppcheck informs.... and I try to avoid the problems.
> 
> 
> Diffs
> -----
> 
>   filters/karbon/svg/SvgParser.cpp 92cd0e1 
>   filters/tables/libkspreadexport/KSpreadLeader.cc c3456fc 
>   filters/words/mswrite/structures_private.cpp 92afab5 
>   krita/plugins/filters/phongbumpmap/phongbumpmap.cpp 6ba90dc 
>   libs/kotext/changetracker/KoTextShapeData.cpp dd79b1b 
>   libs/main/KoMainWindow.cpp 12e7e09 
> 
> Diff: http://git.reviewboard.kde.org/r/101796/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaime Torres
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110629/61ffa5dd/attachment.htm>