Review Request: Review request for tagging functionality in the branch krita_resource-management-tagging-tiyyagura and also merging this branch into master

[Srikanth Tiyyagura]

> On June 28, 2011, 8:38 a.m., Boudewijn Rempt wrote:
> > good work, but a couple of remarks:
> > 
> > * there really should be a unittest for the new tagging class
> > * interaction wise, there is still some room for improvement. 
> > 
> > ** The icons under the tagging lineedit seem to belong to the tagging process, but they don't. Maybe the tooltips for the icons can be improved.
> > 
> > ** It's not clear how I can actually search for resources with a tag. I added a couple of tags to one preset, then entered a tag in the "search Preset" line edit -- but that only searched by filename.  I think it should also search by by tag. This seems to work fine for for instance gradients.
> > 
> > ** The tag lineedit gets enabled in the popup when a tag is selected for the first time, but not disabled when tags are no longer selected. This is kind of confusing.
> > 
> > ** there should be a way to select more than one resource at a time so we can apply a tag to all of those.
> 
> Sven Langkamp wrote:
>     I think it shouldn't be possible to select more than one resource. It's not feasible to determine the selected resource in that case. Would be better to add a seperate resource manager for that.

Ideas for solving above mentioned improvements.

** The icons under the tagging lineedit seem to belong to the tagging process, but they don't. Maybe the tooltips for the icons can be improved.

 For this I thought we can change tool tips as
Import - Import Resource
Delete - Delete Resource
Download - Download Resource
Share - Share resource

** It's not clear how I can actually search for resources with a tag. I added a couple of tags to one preset, then entered a tag in the "search Preset" line edit -- but that only searched by filename.  I think it should also search by by tag. This seems to work fine for for instance gradients.

Actually for searching tags, I choose returnPressed signal rather than textChanged thinking that resources are reterived mainly by tag full names and also we are providing autoComplete option. 

So, we need to press enter after typing tag whenever we need to search for resources by tags.


** The tag lineedit gets enabled in the popup when a tag is selected for the first time, but not disabled when tags are no longer selected. This is kind of confusing.

The Tag LineEdit will be enabled when we press a resource. 

If there are no tags attached to the resource, tag linedit shows "Add / Delete Tag". 
And if there are tags for the resource, tags are displayed in the tagging lineEdit


- Srikanth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101793/#review4227
-----------------------------------------------------------


On June 28, 2011, 1:29 a.m., Srikanth Tiyyagura wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101793/
> -----------------------------------------------------------
> 
> (Updated June 28, 2011, 1:29 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Tagging for the resources is completed and needs a review for merging into master. So, I created a diff file between master and krita_resource-management-tagging-tiyyagura branches and posted that here.
> 
> I think all the functionalities required are implemented; If I miss anything, please suggest me the ideas and I will implement them into tagging.
> 
> 
> Diffs
> -----
> 
>   krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp 33e5310 
>   krita/ui/kis_palette_manager.cpp e16d748 
>   krita/ui/widgets/kis_gradient_chooser.cc 6852c0b 
>   krita/ui/widgets/kis_paintop_presets_chooser_popup.h 557d1d5 
>   krita/ui/widgets/kis_paintop_presets_chooser_popup.cpp 54f7bc0 
>   krita/ui/widgets/kis_pattern_chooser.cc 4a08ea9 
>   krita/ui/widgets/kis_preset_chooser.h a27dfaa 
>   krita/ui/widgets/kis_preset_chooser.cpp 30b624c 
>   libs/widgets/CMakeLists.txt 6ff1df9 
>   libs/widgets/KoResourceItemChooser.h 245e727 
>   libs/widgets/KoResourceItemChooser.cpp 5ef3d63 
>   libs/widgets/KoResourceServer.h fbae66e 
>   libs/widgets/KoResourceServerAdapter.h 5422fe3 
>   libs/widgets/KoResourceTagging.h PRE-CREATION 
>   libs/widgets/KoResourceTagging.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101793/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110628/0ec5f37a/attachment.htm>