Review Request: Stage: GSoC: Add rename slides function in Slides Sorter View

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101661/#review4019
-----------------------------------------------------------

Ship it!


Please fix the 2 thinks I noticed and then commit it. Good work.


kpresenter/part/KPrSlidesSorterDocumentModel.cpp
<http://git.reviewboard.kde.org/r/101661/#comment3283>

    Please use { } even for single line if statements as defined in the code style.



kpresenter/part/KPrViewModeSlidesSorter.h
<http://git.reviewboard.kde.org/r/101661/#comment3284>

    Please pass as a const reference. No need to copy the list.


- Thorsten


On June 17, 2011, 8:28 p.m., Paul Mendez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101661/
> -----------------------------------------------------------
> 
> (Updated June 17, 2011, 8:28 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> Add rename slides funtion to the slides sorter view (standard edition keys and context menu action)
> Fix deselection of items when moving multiple slides.
> 
> 
> Diffs
> -----
> 
>   kpresenter/part/KPrSlidesSorterDocumentModel.h 70c1aac2ea0dcc7ebcdb886cc03512bc5a68e046 
>   kpresenter/part/KPrSlidesSorterDocumentModel.cpp c2dbdcefbf3378c2f40700fa2dc43b4666df431b 
>   kpresenter/part/KPrViewModeSlidesSorter.h 8a6d9f9cd6b9a39b9baa8467cf5633cd67e2712d 
>   kpresenter/part/KPrViewModeSlidesSorter.cpp 2b9c8b60a4ec15e2cef5caa74aa7614e6b5ba16d 
> 
> Diff: http://git.reviewboard.kde.org/r/101661/diff
> 
> 
> Testing
> -------
> 
> build and run
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110619/7bd6d421/attachment.htm>